Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterator over ENV leaves extra null terminator in values on windows. #18141

Closed
twadleigh opened this issue Aug 19, 2016 · 0 comments
Closed

Iterator over ENV leaves extra null terminator in values on windows. #18141

twadleigh opened this issue Aug 19, 2016 · 0 comments
Labels
bug Indicates an unexpected problem or unintended behavior system:windows Affects only Windows

Comments

@twadleigh
Copy link
Contributor

A (truncated) dump of ENV:

julia> ENV
Base.EnvHash with 71 entries:
  "=::"                      => "::\\\0"
  "ALLUSERSPROFILE"          => "C:\\ProgramData\0"
  "APPDATA"                  => "C:\\Users\\hw9980\\AppData\\Roaming\0"
  "COMMONPROGRAMFILES"       => "C:\\Program Files\\Common Files\0"
  "COMPUTERNAME"             => "SNC39466\0"
  "COMSPEC"                  => "C:\\WINDOWS\\system32\\cmd.exe\0"
  "ChocolateyInstall"        => "C:\\ProgramData\\chocolatey\0"
  "ChocolateyLastPathUpdate" => "Tue Jul 19 11:05:47 2016\0"
  "CommonProgramFiles(x86)"  => "C:\\Program Files (x86)\\Common Files\0"
  "CommonProgramW6432"       => "C:\\Program Files\\Common Files\0"
twadleigh added a commit to twadleigh/julia that referenced this issue Aug 19, 2016
@twadleigh
Fixes JuliaLang#18141, removing trailing null in ENV iterator on wind…
5045652 
…ows.
twadleigh added a commit to twadleigh/julia that referenced this issue Aug 19, 2016
@twadleigh
Eliminate trailing null from iterator over ENV.
953271a 
Fixes JuliaLang#18141.
@twadleigh twadleigh mentioned this issue Aug 19, 2016
Merged
twadleigh added a commit to twadleigh/julia that referenced this issue Aug 19, 2016
@twadleigh
Add failing test for JuliaLang#18141.
354cbe6
twadleigh added a commit to twadleigh/julia that referenced this issue Aug 19, 2016
@twadleigh
Add failing test for JuliaLang#18141.
fce6830
@JeffBezanson JeffBezanson added bug Indicates an unexpected problem or unintended behavior system:windows Affects only Windows labels Aug 19, 2016
twadleigh added a commit to twadleigh/julia that referenced this issue Aug 20, 2016
@twadleigh
Fixes JuliaLang#18141, removing trailing null in ENV iterator on wind…
f6b8f11 
…ows.
twadleigh added a commit to twadleigh/julia that referenced this issue Aug 20, 2016
@twadleigh
Add failing test for JuliaLang#18141.
688140a
tkelman pushed a commit that referenced this issue Aug 20, 2016
@twadleigh @tkelman
Fixes #18141, eliminating null in value when iterating over ENV. (#…
03e7c79 
…18144)

* Eliminate trailing null from iterator over `ENV`.

Fixes #18141.

* Add failing test for #18141.
tkelman pushed a commit that referenced this issue Aug 20, 2016
@twadleigh @tkelman
Fixes #18141, eliminating null in value when iterating over ENV. (#…
293f63a 
…18144)

* Eliminate trailing null from iterator over `ENV`.

Fixes #18141.

* Add failing test for #18141.

(cherry picked from commit 03e7c79)
mfasi pushed a commit to mfasi/julia that referenced this issue Sep 5, 2016
@twadleigh @mfasi
Fixes JuliaLang#18141, eliminating null in value when iterating over …
f238e5b 
…`ENV`. (JuliaLang#18144)

* Eliminate trailing null from iterator over `ENV`.

Fixes JuliaLang#18141.

* Add failing test for JuliaLang#18141.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeffBezanson @twadleigh