-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make coverage/alloc work without turning off inlining #17476
Comments
I'm glad to hear that. +1. thanks |
This may already be well-known, but I just (re)discovered an interesting problem while working on an upcoming package, IndirectArrays, in which running our tests with CC @blakejohnson, in case you haven't discovered this issue yet. (To be clear, I think the fix is to improve the way we measure coverage, not to change how |
@timholy right, we go through some hoops to run the base boundscheck tests 3 different ways to test all code paths. As a first step, to get the test to pass with or without inlining, you can modify the test based upon the value of |
Now with our improved
meta
information, I wonder if in principle it's possible to make coverage analysis work properly without--inline=no
. Ref c68a2cdThe text was updated successfully, but these errors were encountered: