-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSFMT needs a 64-bit interface #1556
Comments
If we do add this, we should contribute the additions upstream if it's reasonable to do so. |
Arguably one could also just use the 32-bit interface in a loop for 64-bit values that are large. That would be a Julia-only solution. |
I will at least try patch DSFMT to use long instead of int. I think it should be reasonably simple to pull off, and we already patch DSFMT. |
As of commit c78b184
|
I have to say, I rather like the vertical ellipsis :-) I guess this works, but I still don't get why we're not just calling the 32-bit interface in a loop. Is there some reason not to do that instead? |
This was just quicker to do, rather than changing a whole bunch of dsfmt wrappers! |
DSFMT needs a 64-bit interface. Currently, it seems to use
int
for array sizes.The text was updated successfully, but these errors were encountered: