-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
whos() considerably slow #14173
Comments
That is really bad. The problem is mainly this line which prints the object. Unfortunately, it prints all the values of the array, which takes quite long time because your array is large. It shouldn't print all the values, but instead do something like we are doing when printing an array in the REPL, but our array printing code is really convoluted, so I'm not sure there is an easy fix. Hopefully #14052 will be a long term fix for easier array printing, but I'm not sure it is worth the trouble to print the objects in |
Wouldn't replacing that line with |
I am fairly new to Julia, and am really fascinated by it. All I did was |
Unfortunately, |
@andreasnoack So is that a feature to come in a future release? |
I really liked the current behavior (printing head and tail of a big matrix) of the printing function. I hope #14177 does not change that. Instead, |
We should not be trying to show whole values during |
@JeffBezanson That is also what I've ended up doing in #14177. |
The old threshold causes this test to fail in MEMDEBUG mode
The old threshold causes this test to fail in MEMDEBUG mode (cherry picked from commit 78bc312)
The test failed again in MEMDEBUG mode, allocating 19776 bytes (while only 6096 with MEMDEBUG off). Before #14173, the test allocated 1597240656 bytes, so it is safe to bump this value to 50k.
Use it to fix the #14173 test in the case of MEMDEBUG.
Use it to fix the #14173 test in the case of MEMDEBUG.
Expose MEMDEBUG, and use it to fix the #14173 test
Expose MEMDEBUG, and use it to fix the #14173 test
One of my ASAN CI builds allocated 21056 bytes on this test, so tweaking the thresholds yet again...
Increase MEMDEBUG allocation threshold for #14173 test
julia> @time whos()
Base 24573 KB Module : Base
Core 3043 KB Module : Core
Main 808579 KB Module : Main
ans 0 bytes Void : nothing
x 781250 KB 10000x10000 Array{Float64,2} : [0.2345839889343943…
α̂₂ 8 bytes Int64 : 2
203.371041 seconds (1.58 G allocations: 34.022 GB, 4.22% gc time)
The text was updated successfully, but these errors were encountered: