Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build fails with JULIA_THREADS=1 #14028

Closed
josefsachsconning opened this issue Nov 17, 2015 · 3 comments · Fixed by #14045
Closed

Build fails with JULIA_THREADS=1 #14028

josefsachsconning opened this issue Nov 17, 2015 · 3 comments · Fixed by #14045
Labels
building Build system, or building Julia or its dependencies multithreading Base.Threads and related functionality

Comments

@josefsachsconning
Copy link
Contributor

On master, starting at ab9389c.

$ make
    JULIA usr/lib/julia/inference0.ji
/home/sachs/src/julia-multithreading/usr/bin/julia: symbol lookup error: /home/sachs/src/julia-multithreading/usr/bin/../lib/libjulia.so: undefined symbol: jl_set_stackbase
make[1]: *** [/home/sachs/src/julia-multithreading/usr/lib/julia/inference0.ji] Error 127
make: *** [julia-inference] Error 2
@tkelman tkelman added the multithreading Base.Threads and related functionality label Nov 17, 2015
@stevengj stevengj added the building Build system, or building Julia or its dependencies label Nov 17, 2015
josefsachsconning referenced this issue Nov 18, 2015
@vtjnash
Merge pull request #13963 from JuliaLang/jn/task_enhancements
ab9389c 
small enhancements to Task
@ArchRobison
Copy link
Contributor

I'm looking at it and will attempt a fix.

Looks like b238ac2 removed jl_set_stackbase on Sept. 10, though I thought I had built the multi-threaded version successfully last week. It must be some aspect of git merging that I don't understand.

@tkelman
Copy link
Contributor

tkelman commented Nov 18, 2015

If you follow the link to the pull request that commit came from, #13963, it was only merged 2 days ago.

@ArchRobison
Copy link
Contributor

Thanks for the enlightenment. It hadn't registered with me that merging preserves the original date.

ArchRobison pushed a commit to ArchRobison/julia that referenced this issue Nov 18, 2015
Set jl_stackbase (fixes JuliaLang#14028).
02a9315 
An earlier commit removed jl_set_stackbase, but it was still required
when building with JULIA_THREADS=1.  The fix makes jl_set_base_ctx
do the work that jl_set_stackabase did.
ArchRobison pushed a commit to ArchRobison/julia that referenced this issue Nov 18, 2015
Set jl_stackbase (fixes JuliaLang#14028).
5049185 
An earlier commit removed jl_set_stackbase, but it was required
when building with JULIA_THREADS=1.  The fix makes jl_set_base_ctx
do the work that jl_set_stackbase did.
@ArchRobison ArchRobison mentioned this issue Nov 18, 2015
Merged
ArchRobison pushed a commit that referenced this issue Nov 18, 2015
@tkelman
Set jl_stackbase (fixes #14028).
1d8a5cd 
An earlier commit removed jl_set_stackbase, but it was required
when building with JULIA_THREADS=1.  The fix makes jl_set_base_ctx
do the work that jl_set_stackbase did.
zhmz90 pushed a commit to zhmz90/julia that referenced this issue Nov 19, 2015
Set jl_stackbase (fixes JuliaLang#14028).
1e6c51e 
An earlier commit removed jl_set_stackbase, but it was required
when building with JULIA_THREADS=1.  The fix makes jl_set_base_ctx
do the work that jl_set_stackbase did.
ArchRobison pushed a commit to ArchRobison/julia that referenced this issue Nov 19, 2015
Set jl_stackbase (fixes JuliaLang#14028).
a8b2f62 
An earlier commit removed jl_set_stackbase, but it was required
when building with JULIA_THREADS=1.  The fix makes jl_set_base_ctx
do the work that jl_set_stackbase did.
zhmz90 pushed a commit to zhmz90/julia that referenced this issue Nov 21, 2015
Set jl_stackbase (fixes JuliaLang#14028).
c5db2b5 
An earlier commit removed jl_set_stackbase, but it was required
when building with JULIA_THREADS=1.  The fix makes jl_set_base_ctx
do the work that jl_set_stackbase did.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set jl_stackbase for worker threads ArchRobison/julia
4 participants
@stevengj @ArchRobison @tkelman @josefsachsconning