Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atsign-doc forces functions to be imported/extended #11798

Closed
timholy opened this issue Jun 21, 2015 · 2 comments
Closed

atsign-doc forces functions to be imported/extended #11798

timholy opened this issue Jun 21, 2015 · 2 comments
Assignees
Labels
docsystem The documentation building system

Comments

@timholy
Copy link
Member

timholy commented Jun 21, 2015

This works:

module Doc

@doc "read" ->
Base.read(filename) = 1

end

but if you take away the Base. (to require folks to call read as Doc.read) then you get

julia> using Doc
ERROR: LoadError: error in method definition: function Base.read must be explicitly imported to be extended
 in include at ./boot.jl:254
 in include_from_node1 at ./loading.jl:133
 in reload_path at ./loading.jl:157
 in _require at ./loading.jl:69
 in require at ./loading.jl:52
while loading /tmp/Doc.jl, in expression starting on line 3

Naturally, a function that does not have a name-conflict with Base does not have this problem.

@timholy timholy added the docs This change adds or pertains to documentation label Jun 21, 2015
@quinnj quinnj added docsystem The documentation building system and removed docs This change adds or pertains to documentation labels Jun 28, 2015
@MichaelHatherly
Copy link
Member

@one-more-minute I've got a possible fix for this. Unless you've been working on this already I'll PR it in a bit.

@MikeInnes MikeInnes self-assigned this Jun 29, 2015
@MikeInnes
Copy link
Member

Sure, would be great to see what you got.

MichaelHatherly added a commit to MichaelHatherly/julia that referenced this issue Jun 29, 2015
MichaelHatherly added a commit to MichaelHatherly/julia that referenced this issue Jun 29, 2015
MichaelHatherly added a commit to MichaelHatherly/julia that referenced this issue Jun 29, 2015
MichaelHatherly added a commit to MichaelHatherly/julia that referenced this issue Jul 5, 2015
MichaelHatherly added a commit to MichaelHatherly/julia that referenced this issue Jul 9, 2015
MichaelHatherly added a commit to MichaelHatherly/julia that referenced this issue Aug 4, 2015
MikeInnes added a commit that referenced this issue Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docsystem The documentation building system
Projects
None yet
Development

No branches or pull requests

4 participants