Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectors should be compatible with columns wherever possible #113

Closed
ghost opened this issue Jul 15, 2011 · 4 comments
Closed

Vectors should be compatible with columns wherever possible #113

ghost opened this issue Jul 15, 2011 · 4 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@ghost
Copy link

ghost commented Jul 15, 2011

You need to double-transpose vectors to make them into 1-column matrices so that
you can add them to 1-column matrices or multiply them with one-row matrices (on
either side).

@ViralBShah
Copy link
Member

We need a general way to address this throughout our array implementation.

@JeffBezanson
Copy link
Member

I tried the following cases and they all worked:

a=rand(3,3); v= rand(3);
a[:,1]=v
a[1,:]=v
a[:,1]+v
a[1,:]*v
v*a[1,:]

And this works but there's an issue saying maybe it shouldn't:

a[1,:]+v

Can we find any examples of cases that are still failing?

@JeffBezanson
Copy link
Member

Due to our improved error checking, this happens:

julia> [1 2 3]' + [1,2,3]
argument dimensions must match
in +, /home/jeff/src/julia2/julia/j/abstractarray.j:203

Should we define dims_match(a,b) that allows dims to match in the presence of trailing ones?

@JeffBezanson
Copy link
Member

Duplicate of #231.

cmcaine pushed a commit to cmcaine/julia that referenced this issue Sep 24, 2020
Add auto_approve to hello-world exercise
LilithHafner pushed a commit to LilithHafner/julia that referenced this issue Oct 11, 2021
inkydragon pushed a commit that referenced this issue Dec 15, 2024
Stdlib: SHA
URL: https://github.com/JuliaCrypto/SHA.jl.git
Stdlib branch: master
Julia branch: master
Old commit: aaf2df6
New commit: 8fa221d
Julia version: 1.12.0-DEV
SHA version: 0.7.0(Does not match)
Bump invoked by: @inkydragon
Powered by:
[BumpStdlibs.jl](https://github.com/JuliaLang/BumpStdlibs.jl)

Diff:
JuliaCrypto/SHA.jl@aaf2df6...8fa221d

```
$ git log --oneline aaf2df6..8fa221d
8fa221d ci: update doctest config (#120)
346b359 ci: Update ci config (#115)
aba9014 Fix type mismatch for `shake/digest!` and setup x86 ci (#117)
0b76d04 Merge pull request #114 from JuliaCrypto/dependabot/github_actions/codecov/codecov-action-5
5094d9d Update .github/workflows/CI.yml
45596b1 Bump codecov/codecov-action from 4 to 5
230ab51 test: remove outdate tests (#113)
7f25aa8 rm: Duplicated const alias (#111)
aa72f73 [SHA3] Fix padding special-case (#108)
3a01401 Delete Manifest.toml (#109)
da351bb Remvoe all getproperty funcs (#99)
4eee84f Bump codecov/codecov-action from 3 to 4 (#104)
15f7dbc Bump codecov/codecov-action from 1 to 3 (#102)
860e6b9 Bump actions/checkout from 2 to 4 (#103)
8e5f0ea Add dependabot to auto update github actions (#100)
4ab324c Merge pull request #98 from fork4jl/sha512-t
a658829 SHA-512: add ref to NIST standard
11a4c73 Apply suggestions from code review
969f867 Merge pull request #97 from fingolfin/mh/Vector
b1401fb SHA-512: add NIST test
4d7091b SHA-512: add to docs
09fef9a SHA-512: test SHA-512/224, SHA-512/256
7201b74 SHA-512: impl SHA-512/224, SHA-512/256
4ab85ad Array -> Vector
8ef91b6 fixed bug in padding for shake, addes testcases for full code coverage (#95)
88e1c83 Remove non-existent property (#75)
068f85d shake128,shake256: fixed typo in export declarations (#93)
176baaa SHA3 xof shake128 and shake256  (#92)
e1af7dd Hardcode doc edit backlink
```

Co-authored-by: Dilum Aluthge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants