-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
_methods
for unions
- Loading branch information
There are no files selected for viewing
4 comments
on commit ee0c3ed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 @vtjnash and I were looking at something very similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Keno can you push yours to a PR also, these two changes should be very complimentary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inference.jl change as well or was that just a temporary hack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both. i ended up just pushing the commit myself 26d7bb8
i found that this breaks a few tests, however, since it can also be too pessimistic in certain cases (and thus potentially break static_typeof).
this should probably be
nunions *= length(ti.types)