use tempdir instead of tempname in test/pkg.jl

since tempname creates a file on windows, but the goal here is creating a directory. also don't try to delete nonexistent files during cleanup
JuliaLang · Nov 22, 2014 · dd6cd5a · dd6cd5a
1 parent 83f8018
commit dd6cd5a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/base/pkg/dir.jl b/base/pkg/dir.jl
@@ -48,7 +48,7 @@ function init(meta::String=DEFAULT_META, branch::String=META_BRANCH)
             run(`touch REQUIRE`)
         end
     catch e
-        rm(dir, recursive=true)
+        ispath(dir) && rm(dir, recursive=true)
         rethrow(e)
     end
 end

diff --git a/test/pkg.jl b/test/pkg.jl
@@ -1,6 +1,6 @@
 function temp_pkg_dir(fn::Function)
   # Used in tests below to setup and teardown a sandboxed package directory
-  const tmpdir = ENV["JULIA_PKGDIR"] = tempname()
+  const tmpdir = ENV["JULIA_PKGDIR"] = joinpath(tempdir(),randstring())
   @test !isdir(Pkg.dir())
   try
     Pkg.init()