Skip to content

Commit

Permalink
Disable startup files in misc. tests that spawn julia_cmd (#31421)
Browse files Browse the repository at this point in the history
  • Loading branch information
musm authored and StefanKarpinski committed Mar 28, 2019
1 parent 9686d88 commit d60503a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion stdlib/Sockets/test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ end
srv = listen(addr)
s = connect(addr)

@test success(pipeline(`$(Base.julia_cmd()) -e "exit()" -i`, stdin=s))
@test success(pipeline(`$(Base.julia_cmd()) --startup-file=no -e "exit()" -i`, stdin=s))

close(s)
close(srv)
Expand Down
10 changes: 5 additions & 5 deletions test/loading.jl
Original file line number Diff line number Diff line change
Expand Up @@ -571,9 +571,9 @@ end
cd("foo")
@test Base.active_project() == old
"""
@test success(`$(Base.julia_cmd()) --project=foo -e $(script)`)
@test success(`$(Base.julia_cmd()) --startup-file=no --project=foo -e $(script)`)
withenv("JULIA_PROJECT" => "foo") do
@test success(`$(Base.julia_cmd()) -e $(script)`)
@test success(`$(Base.julia_cmd()) --startup-file=no -e $(script)`)
end
end; end
end
Expand All @@ -589,7 +589,7 @@ mktempdir() do dir
mkpath(vpath)
withenv("JULIA_DEPOT_PATH" => dir) do
script = "@assert startswith(Base.active_project(), $(repr(vpath)))"
@test success(`$(Base.julia_cmd()) -e $(script)`)
@test success(`$(Base.julia_cmd()) --startup-file=no -e $(script)`)
end
end

Expand All @@ -606,7 +606,7 @@ end
for (env, result) in pairs(cases)
withenv("JULIA_LOAD_PATH" => env) do
script = "LOAD_PATH == $(repr(result)) || error()"
@test success(`$(Base.julia_cmd()) -e $script`)
@test success(`$(Base.julia_cmd()) --startup-file=no -e $script`)
end
end
end
Expand All @@ -625,7 +625,7 @@ end
for (env, result) in pairs(cases)
withenv("JULIA_DEPOT_PATH" => env) do
script = "DEPOT_PATH == $(repr(result)) || error()"
@test success(`$(Base.julia_cmd()) -e $script`)
@test success(`$(Base.julia_cmd()) --startup-file=no -e $script`)
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions test/spawn.jl
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ end

# Logging macros should not output to finalized streams (#26687)
let
cmd = `$(Base.julia_cmd()) -e 'finalizer(x->@info(x), "Hello")'`
cmd = `$exename --startup-file=no -e 'finalizer(x->@info(x), "Hello")'`
output = readchomp(pipeline(cmd, stderr=catcmd))
@test occursin("Info: Hello", output)
end
Expand Down Expand Up @@ -614,7 +614,7 @@ end

let text = "input-test-text"
b = PipeBuffer()
proc = open(Base.CmdRedirect(Base.CmdRedirect(```$(Base.julia_cmd()) -E '
proc = open(Base.CmdRedirect(Base.CmdRedirect(```$exename --startup-file=no -E '
in14 = Base.open(RawFD(14))
out15 = Base.open(RawFD(15))
write(out15, in14)'```,
Expand Down

2 comments on commit d60503a

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.