Skip to content

Commit

Permalink
Don't set CMAKE_INSTALL_<dir>.
Browse files Browse the repository at this point in the history
According to the docs, https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html#module:GNUInstallDirs,
it should be a relative path that will automatically be prefixed wit the CMAKE_INSTALL_PREFIX (which
we already set). That means the default values, https://cmake.org/cmake/help/latest/command/install.html,
should work just fine.
  • Loading branch information
maleadt committed Jul 15, 2022
1 parent ce9a659 commit c73f81b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion deps/tools/common.mk
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ CMAKE_CC_ARG := $(CC_ARG)
CMAKE_CXX_ARG := $(CXX_ARG)

CMAKE_COMMON := -DCMAKE_INSTALL_PREFIX:PATH=$(build_prefix) -DCMAKE_PREFIX_PATH=$(build_prefix)
CMAKE_COMMON += -DCMAKE_INSTALL_LIBDIR=$(build_libdir) -DCMAKE_INSTALL_BINDIR=$(build_bindir)
CMAKE_COMMON += -DLIB_INSTALL_DIR=$(build_shlibdir)
ifeq ($(OS), Darwin)
CMAKE_COMMON += -DCMAKE_MACOSX_RPATH=1
Expand Down

0 comments on commit c73f81b

Please sign in to comment.