Skip to content

Commit

Permalink
Only download UnicodeData.txt once (#19794)
Browse files Browse the repository at this point in the history
Verify the checksums on every run, but only download the file if missing.
Also fix path in error message when checksum doesn't match by tweaking
jlchecksum a bit so that it doesn't assume all files are saved into
deps/srccache.
  • Loading branch information
nalimilan authored and tkelman committed Jan 1, 2017
1 parent 205c12b commit c38a5a3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion deps/tools/jlchecksum
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ checksum_error()
echo " But \`$CHECKSUM_PROG\` results in:" >&2
print_hash "$CURR_CHECKSUM"
echo " This can happen due to bad downloads or network proxies, please check your" >&2
echo " network proxy/firewall settings and delete deps/srccache/$BASENAME" >&2
echo " network proxy/firewall settings and delete" >&2
echo " $(realpath $ARG1)" >&2
echo " to force a redownload when you are ready" >&2
echo "===============================================================================" >&2
exit 2
Expand Down
4 changes: 3 additions & 1 deletion doc/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ help:
@echo " doctest to run all doctests embedded in the documentation"
@echo " check to run linkcheck and doctests"

deps:
UnicodeData.txt:
$(JLDOWNLOAD) http://www.unicode.org/Public/9.0.0/ucd/UnicodeData.txt

deps: UnicodeData.txt
$(JLCHECKSUM) UnicodeData.txt

clean:
Expand Down

2 comments on commit c38a5a3

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

Please sign in to comment.