Skip to content

Commit

Permalink
fix an instance of getting mapany from Base (#37419)
Browse files Browse the repository at this point in the history
  • Loading branch information
KristofferC authored Sep 6, 2020
1 parent be99339 commit bf886b5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion base/broadcast.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1173,7 +1173,7 @@ function undot(x::Expr)
if x.head === :.=
Expr(:(=), x.args...)
elseif x.head === :block # occurs in for x=..., y=...
Expr(:block, mapany(undot, x.args)...)
Expr(:block, Base.mapany(undot, x.args)...)
else
x
end
Expand Down
6 changes: 6 additions & 0 deletions test/broadcast.jl
Original file line number Diff line number Diff line change
Expand Up @@ -938,3 +938,9 @@ ret = @macroexpand @.([Int, Number] <: Real)

ret = @macroexpand @.([Int, Number] >: Real)
@test ret == :([Int, Number] .>: Real)

# Threw mapany not defined
p = rand(4,4); r = rand(2,4);
p0 = copy(p)
@views @. p[1:2, :] += r
@test p[1:2, :] p0[1:2, :] + r

3 comments on commit bf886b5

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.