Avoid impossible unionall normalization (#42003)

If the unionall bounds are inconsistent with the wrapper's bound, avoid throwing due to an impossible type instantiation.
JuliaLang · Sep 1, 2021 · b5b0684 · b5b0684
1 parent b21d2de
commit b5b0684
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/jltypes.c b/src/jltypes.c
@@ -1326,8 +1326,15 @@ jl_value_t *normalize_unionalls(jl_value_t *t)
             u = (jl_unionall_t*)t;
         }
 
-        if (u->var->lb == u->var->ub || may_substitute_ub(body, u->var))
-            t = jl_instantiate_unionall(u, u->var->ub);
+        if (u->var->lb == u->var->ub || may_substitute_ub(body, u->var)) {
+            JL_TRY {
+                t = jl_instantiate_unionall(u, u->var->ub);
+            }
+            JL_CATCH {
+                // just skip normalization
+                // (may happen for bounds inconsistent with the wrapper's bounds)
+            }
+        }
     }
     JL_GC_POP();
     return t;

diff --git a/test/core.jl b/test/core.jl
@@ -7586,3 +7586,6 @@ let S = Tuple{Tuple{Tuple{K, UInt128} where K<:Tuple{Int64}, Int64}},
     @test pointer_from_objref(T) === pointer_from_objref(S)
     @test isbitstype(T)
 end
+
+# avoid impossible normalization (don't try to form Tuple{Complex{String}} here)
+@test Tuple{Complex{T} where String<:T<:String} == Tuple{Complex{T} where String<:T<:String}