Skip to content

Commit

Permalink
Don't overwrite the cp function in the arrayops test
Browse files Browse the repository at this point in the history
  • Loading branch information
tkelman committed Mar 1, 2017
1 parent 649714d commit b08227b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/arrayops.jl
Original file line number Diff line number Diff line change
Expand Up @@ -478,10 +478,10 @@ end
@test_throws ArgumentError permutedims(s, (1,1,1))
@test_throws ArgumentError Base.PermutedDimsArrays.PermutedDimsArray(a, (1,1,1))
@test_throws ArgumentError Base.PermutedDimsArrays.PermutedDimsArray(s, (1,1,1))
cp = Base.PermutedDimsArrays.PermutedDimsArray(c, (3,2,1))
@test pointer(cp) == pointer(c)
@test_throws ArgumentError pointer(cp, 2)
@test strides(cp) == (9,3,1)
cptr = Base.PermutedDimsArrays.PermutedDimsArray(c, (3,2,1))
@test pointer(cptr) == pointer(c)
@test_throws ArgumentError pointer(cptr, 2)
@test strides(cptr) == (9,3,1)
ap = Base.PermutedDimsArrays.PermutedDimsArray(collect(a), (2,1,3))
@test strides(ap) == (3,1,12)

Expand Down

2 comments on commit b08227b

@tkelman
Copy link
Contributor Author

@tkelman tkelman commented on b08227b Mar 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at commit b08227b: @nanosoldier runbenchmarks(ALL, vs = "@3c9d75391c72d7c32eea75ff187ce77b2d5effc8")

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @jrevels

Please sign in to comment.