Revert "Allocation profiler (#42768)"

This reverts commit ef23d6d.
JuliaLang · Jan 20, 2022 · adb673e · adb673e
1 parent 487f0b4
commit adb673e
Show file tree

Hide file tree

Showing 13 changed files with 2 additions and 620 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -139,9 +139,6 @@ Standard library changes
   Further, percent utilization is now reported as a total or per-thread, based on whether the thread is idle or not at
   each sample. `Profile.fetch()` by default strips out the new metadata to ensure backwards compatibility with external
   profiling data consumers, but can be included with the `include_meta` kwarg. ([#41742])
-* The new `Profile.Allocs` module allows memory allocations to be profiled. The stack trace, type, and size of each
-  allocation is recorded, and a `sample_rate` argument allows a tunable amount of allocations to be skipped,
-  reducing performance overhead. ([#42768])
 
 #### Random
 

diff --git a/doc/src/manual/profile.md b/doc/src/manual/profile.md
@@ -336,31 +336,6 @@ and how much garbage it collects each time. This can be enabled with
 [`GC.enable_logging(true)`](@ref), which causes Julia to log to stderr every time
 a garbage collection happens.
 
-### Allocation Profiler
-
-The allocation profiler records the stack trace, type, and size of each
-allocation while it is running. It can be invoked with
-[`Profile.Allocs.@profile`](@ref).
-
-This information about the allocations is returned as an array of `Alloc`
-objects, wrapped in an `AllocResults` object. The best way to visualize
-these is currently with the [PProf.jl](https://github.com/JuliaPerf/PProf.jl)
-library, which can visualize the call stacks which are making the most
-allocations.
-
-The allocation profiler does have significant overhead, so a `sample_rate`
-argument can be passed to speed it up by making it skip some allocations.
-Passing `sample_rate=1.0` will make it record everything (which is slow);
-`sample_rate=0.1` will record only 10% of the allocations (faster), etc.
-
-!!! note
-
-    The current implementation of the Allocations Profiler _does not
-    capture all allocations._ You can read more about the missing allocations
-    and the plan to improve this, here: https://github.com/JuliaLang/julia/issues/43688.
-    Calling `Profile.Allocs.fetch()` will print a log line reporting the percentage
-    of missed allocations, so you can understand the accuracy of your profile.
-
 ## External Profiling
 
 Currently Julia supports `Intel VTune`, `OProfile` and `perf` as external profiling tools.

diff --git a/src/Makefile b/src/Makefile
@@ -45,7 +45,7 @@ RUNTIME_SRCS := \
 	jltypes gf typemap smallintset ast builtins module interpreter symbol \
 	dlload sys init task array dump staticdata toplevel jl_uv datatype \
 	simplevector runtime_intrinsics precompile \
-	threading partr stackwalk gc gc-debug gc-pages gc-stacks gc-alloc-profiler method \
+	threading partr stackwalk gc gc-debug gc-pages gc-stacks method \
 	jlapi signal-handling safepoint timing subtype \
 	crc32c APInt-C processor ircode opaque_closure codegen-stubs coverage
 SRCS := jloptions runtime_ccall rtutils
@@ -289,7 +289,7 @@ $(BUILDDIR)/disasm.o $(BUILDDIR)/disasm.dbg.obj: $(SRCDIR)/debuginfo.h $(SRCDIR)
 $(BUILDDIR)/dump.o $(BUILDDIR)/dump.dbg.obj: $(addprefix $(SRCDIR)/,common_symbols1.inc common_symbols2.inc builtin_proto.h serialize.h)
 $(BUILDDIR)/gc-debug.o $(BUILDDIR)/gc-debug.dbg.obj: $(SRCDIR)/gc.h
 $(BUILDDIR)/gc-pages.o $(BUILDDIR)/gc-pages.dbg.obj: $(SRCDIR)/gc.h
-$(BUILDDIR)/gc.o $(BUILDDIR)/gc.dbg.obj: $(SRCDIR)/gc.h $(SRCDIR)/gc-alloc-profiler.h
+$(BUILDDIR)/gc.o $(BUILDDIR)/gc.dbg.obj: $(SRCDIR)/gc.h
 $(BUILDDIR)/init.o $(BUILDDIR)/init.dbg.obj: $(SRCDIR)/builtin_proto.h
 $(BUILDDIR)/interpreter.o $(BUILDDIR)/interpreter.dbg.obj: $(SRCDIR)/builtin_proto.h
 $(BUILDDIR)/jitlayers.o $(BUILDDIR)/jitlayers.dbg.obj: $(SRCDIR)/jitlayers.h $(SRCDIR)/codegen_shared.h

diff --git a/src/array.c b/src/array.c
@@ -508,7 +508,6 @@ JL_DLLEXPORT jl_value_t *jl_alloc_string(size_t len)
         s = jl_gc_big_alloc(ptls, allocsz);
     }
     jl_set_typeof(s, jl_string_type);
-    maybe_record_alloc_to_profile(s, len);
     *(size_t*)s = len;
     jl_string_data(s)[len] = 0;
     return s;

diff --git a/src/gc-alloc-profiler.cpp b/src/gc-alloc-profiler.cpp
diff --git a/src/gc-alloc-profiler.h b/src/gc-alloc-profiler.h
diff --git a/src/gc.h b/src/gc.h
@@ -24,7 +24,6 @@
 #endif
 #endif
 #include "julia_assert.h"
-#include "gc-alloc-profiler.h"
 
 #ifdef __cplusplus
 extern "C" {

diff --git a/src/julia_internal.h b/src/julia_internal.h
@@ -9,7 +9,6 @@
 #include "support/hashing.h"
 #include "support/ptrhash.h"
 #include "support/strtod.h"
-#include "gc-alloc-profiler.h"
 #include <uv.h>
 #if !defined(_WIN32)
 #include <unistd.h>
@@ -365,7 +364,6 @@ STATIC_INLINE jl_value_t *jl_gc_alloc_(jl_ptls_t ptls, size_t sz, void *ty)
         v = jl_gc_big_alloc(ptls, allocsz);
     }
     jl_set_typeof(v, ty);
-    maybe_record_alloc_to_profile(v, sz);
     return v;
 }
 

diff --git a/stdlib/Profile/docs/src/index.md b/stdlib/Profile/docs/src/index.md
@@ -1,7 +1,5 @@
 # [Profiling](@id lib-profiling)
 
-## CPU Profiling
-
 ```@docs
 Profile.@profile
 ```
@@ -17,18 +15,3 @@ Profile.retrieve
 Profile.callers
 Profile.clear_malloc_data
 ```
-
-## Memory profiling
-
-```@docs
-Profile.Allocs.@profile
-```
-
-The methods in `Profile.Allocs` are not exported and need to be called e.g. as `Profile.Allocs.fetch()`.
-
-```@docs
-Profile.Allocs.clear
-Profile.Allocs.fetch
-Profile.Allocs.start
-Profile.Allocs.stop
-```