conservatively escape direct arguments of foreigncall

JuliaLang · Jan 24, 2022 · ad727df · ad727df
1 parent 11a386a
commit ad727df
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/base/compiler/ssair/EscapeAnalysis/EscapeAnalysis.jl b/base/compiler/ssair/EscapeAnalysis/EscapeAnalysis.jl
@@ -1234,13 +1234,15 @@ function escape_foreigncall!(astate::AnalysisState, pc::Int, args::Vector{Any})
     add_escape_change!(astate, name, name_info)
     add_liveness_change!(astate, name, pc)
     for i = 1:nargs
+        # COMBAK
         # we should escape this argument if it is directly called,
         # otherwise just impose ThrownEscape if not nothrow
-        if argtypes[i] === Any
-            arg_info = ⊤
-        else
-            arg_info = nothrow ? ⊥ : ThrownEscape(pc)
-        end
+        # if argtypes[i] === Any
+        #     arg_info = ⊤
+        # else
+        #     arg_info = nothrow ? ⊥ : ThrownEscape(pc)
+        # end
+        arg_info = nothrow ? ⊥ : ⊤
         add_escape_change!(astate, args[5+i], arg_info)
         add_liveness_change!(astate, args[5+i], pc)
     end