Skip to content

Commit

Permalink
Version UnicodeData.txt filename (#35383)
Browse files Browse the repository at this point in the history 
We've been downloading multiple different versions of `UnicodeData.txt`
across different branches and trying to keep a consistent checksum.
  • Loading branch information
@staticfloat
staticfloat authored Apr 6, 2020
1 parent 755f479 commit 922891c
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions doc/Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,12 @@ help:
DOCUMENTER_OPTIONS := linkcheck=$(linkcheck) doctest=$(doctest) buildroot=$(call cygpath_w,$(BUILDROOT)) \
texplatform=$(texplatform)

$(SRCCACHE)/UnicodeData.txt:
UNICODE_DATA_VERSION=13.0.0
$(SRCCACHE)/UnicodeData-$(UNICODE_DATA_VERSION).txt:
@mkdir -p "$(SRCCACHE)"
$(JLDOWNLOAD) "$@" http://www.unicode.org/Public/13.0.0/ucd/UnicodeData.txt
$(JLDOWNLOAD) "$@" http://www.unicode.org/Public/$(UNICODE_DATA_VERSION)/ucd/UnicodeData.txt

deps: $(SRCCACHE)/UnicodeData.txt
deps: $(SRCCACHE)/UnicodeData-$(UNICODE_DATA_VERSION).txt
$(JLCHECKSUM) "$<"
cp "$<" UnicodeData.txt

Expand Down

2 comments on commit 922891c

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily benchmark build, I will reply here when finished:

@nanosoldier runbenchmarks(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

Please sign in to comment.