ishermitian(::Diagonal) now checks elementwise for nonreals

Fix #10036
JuliaLang · Feb 3, 2015 · 881719b · 881719b
1 parent 55d7f87
commit 881719b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/base/linalg/diagonal.jl b/base/linalg/diagonal.jl
@@ -33,7 +33,8 @@ function getindex(D::Diagonal, i::Integer)
     zero(eltype(D.diag))
 end
 
-ishermitian(D::Diagonal) = true
+ishermitian{T<:Real}(D::Diagonal{T}) = true
+ishermitian(D::Diagonal) = all(D.diag .== real(D.diag))
 issym(D::Diagonal) = true
 isposdef(D::Diagonal) = all(D.diag .> 0)
 

diff --git a/test/linalg4.jl b/test/linalg4.jl
@@ -148,6 +148,16 @@ for relty in (Float32, Float64, BigFloat), elty in (relty, Complex{relty})
     for op in (+, -, *)
         @test_approx_eq full(op(D, D2)) op(DM, DM2)
     end
+
+    #10036
+    @test issym(D2)
+    @test ishermitian(D2)
+    if elty <: Complex
+        dc = d + im*convert(Vector{elty}, ones(n))
+        D3 = Diagonal(dc)
+        @test issym(D3)
+        @test !ishermitian(D3)
+    end
 end