fix #30030, assignment expr as named tuple element value (#30045)

(cherry picked from commit 69fabf7)
JuliaLang · Nov 28, 2018 · 8664908 · 8664908
1 parent 8302431
commit 8664908
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/julia-syntax.scm b/src/julia-syntax.scm
@@ -1690,7 +1690,9 @@
 
 (define (named-tuple-expr names values)
   `(call (curly (core NamedTuple) (tuple ,@names))
-         (tuple ,@values)))
+         ;; NOTE: don't use `tuple` head, so an assignment expression as a value
+         ;; doesn't turn this into another named tuple.
+         (call (core tuple) ,@values)))
 
 (define (lower-named-tuple lst
                            (dup-error-fn (lambda (name) (string "field name \"" name "\" repeated in named tuple")))

diff --git a/test/syntax.jl b/test/syntax.jl
@@ -1740,3 +1740,9 @@ end
            finally
            end
        end)), :thunk)
+
+# issue #30030
+let x = 0
+    @test (a=1, b=2, c=(x=3)) == (a=1, b=2, c=3)
+    @test x == 3
+end