Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ian Atol <[email protected]>
  • Loading branch information
aviatesk and Ian Atol committed Jan 19, 2022
1 parent ef8cb01 commit 85075ad
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions base/compiler/ssair/EscapeAnalysis/EAUtils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import InteractiveUtils: gen_call_with_extracted_types_and_kwargs
Evaluates the arguments to the function call, determines its types, and then calls
[`code_escapes`](@ref) on the resulting expression.
As with `@code_typed` and its family, any of `code_escapes` keyword arguments can be given
as the optional arguments like `@code_escpase interp=myinterp myfunc(myargs...)`.
as the optional arguments like `@code_escapes interp=myinterp myfunc(myargs...)`.
"""
macro code_escapes(ex0...)
return gen_call_with_extracted_types_and_kwargs(__module__, :code_escapes, ex0)
Expand All @@ -36,7 +36,7 @@ end # @static if EA_AS_PKG
code_escapes(f, argtypes=Tuple{}; [world], [interp]) -> result::EscapeResult
code_escapes(tt::Type{<:Tuple}; [world], [interp]) -> result::EscapeResult
Runs the escape analysis on optimized IR of a genefic function call with the given type signature.
Runs the escape analysis on optimized IR of a generic function call with the given type signature.
Note that the escape analysis runs after inlining, but before any other optimizations.
```julia
Expand Down
2 changes: 1 addition & 1 deletion base/compiler/ssair/EscapeAnalysis/EscapeAnalysis.jl
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ end

# XXX better to be IdSet{Int}?
const FieldEscape = BitSet
const FieldEscapes = Vector{BitSet}
const FieldEscapes = Vector{FieldEscape}
const ArrayEscapes = IdSet{Int}

"""
Expand Down

0 comments on commit 85075ad

Please sign in to comment.