Skip to content

Commit

Permalink
Deprecate bitbroadcast
Browse files Browse the repository at this point in the history
  • Loading branch information
pabloferz committed Dec 30, 2016
1 parent 242de06 commit 715ddd4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 22 deletions.
21 changes: 1 addition & 20 deletions base/broadcast.jl
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ using Base: promote_eltype_op, linearindices, tail, OneTo, to_shape,
_msk_end, unsafe_bitgetindex, bitcache_chunks, bitcache_size, dumpbitcache,
nullable_returntype, null_safe_eltype_op, hasvalue, is_nullable_array
import Base: broadcast, broadcast!
export bitbroadcast, dotview
export broadcast_getindex, broadcast_setindex!
export broadcast_getindex, broadcast_setindex!, dotview

## Broadcasting utilities ##

Expand Down Expand Up @@ -464,24 +463,6 @@ julia> Ref(7) .+ Nullable(3)
"""
@inline broadcast(f, A, Bs...) = broadcast_c(f, containertype(A, Bs...), A, Bs...)

"""
bitbroadcast(f, As...)
Like [`broadcast`](@ref), but allocates a `BitArray` to store the
result, rather then an `Array`.
```jldoctest
julia> bitbroadcast(isodd,[1,2,3,4,5])
5-element BitArray{1}:
true
false
true
false
true
```
"""
@inline bitbroadcast(f, As...) = broadcast!(f, similar(BitArray, broadcast_indices(As...)), As...)

"""
broadcast_getindex(A, inds...)
Expand Down
3 changes: 3 additions & 0 deletions base/deprecated.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1224,4 +1224,7 @@ function quadgk(args...)
end
export quadgk

# Broadcast now returns a BitArray when the resulting eltype is Bool (#17623)
@deprecate bitbroadcast(f, As...) broadcast(f, As...)

# End deprecations scheduled for 0.6
4 changes: 2 additions & 2 deletions test/bitarray.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1138,8 +1138,8 @@ let b1 = trues(v1), b2 = falses(v1)
end
end

let odds = bitbroadcast(isodd, 1:2000)
evens = bitbroadcast(iseven, 1:2000)
let odds = broadcast(isodd, 1:2000)
evens = broadcast(iseven, 1:2000)
for i = 1:2:2000
@test findprev(odds,i) == findprevnot(evens,i) == i
@test findnext(odds,i) == findnextnot(evens,i) == i
Expand Down

0 comments on commit 715ddd4

Please sign in to comment.