Set IPAddr subtypes as scalars for broadcasting (#32133)

* Set IPAddr subtypes as scalars for broadcasting * Add news
JuliaLang · May 27, 2019 · 6ccd5c4 · 6ccd5c4 · nanosoldier · May 28, 2019
1 parent 3243b94
commit 6ccd5c4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -30,6 +30,7 @@ Standard library changes
 * Cmd interpolation (`` `$(x::Cmd) a b c` `` where) now propagates `x`'s process flags
   (environment, flags, working directory, etc) if `x` is the first interpolant and errors
   otherwise ([#24353]).
+* `IPAddr` subtypes now behave like scalars when used in broadcasting ([#32133]).
 
 #### LinearAlgebra
 

diff --git a/stdlib/Sockets/src/IPAddr.jl b/stdlib/Sockets/src/IPAddr.jl
@@ -10,6 +10,9 @@ abstract type IPAddr end
 Base.isless(a::T, b::T) where {T<:IPAddr} = isless(a.host, b.host)
 (dt::Type{<:Integer})(ip::IPAddr) = dt(ip.host)::dt
 
+# Allow IP addresses to broadcast as unwrapped scalars
+Base.Broadcast.broadcastable(ip::IPAddr) = Ref(ip)
+
 struct IPv4 <: IPAddr
     host::UInt32
     IPv4(host::UInt32) = new(host)

diff --git a/stdlib/Sockets/test/runtests.jl b/stdlib/Sockets/test/runtests.jl
@@ -79,6 +79,11 @@ end
     @test_throws MethodError sort([ip"2.3.4.5", ip"1.2.3.4", ip"2001:1:2::1"])
 end
 
+@testset "broadcastable" begin
+    @test size(ip"127.0.0.1" .== ip"127.0.0.1") == ()
+    @test size(ip"::1" .== ip"::1") == ()
+end
+
 @testset "RFC 5952 Compliance" begin
     @test repr(ip"2001:db8:0:0:0:0:2:1") == "ip\"2001:db8::2:1\""
     @test repr(ip"2001:0db8::0001") == "ip\"2001:db8::1\""