fix #30234, don't resolve bindings when tab-completing using (#30254)

(cherry picked from commit b482b09)
JuliaLang · Feb 11, 2019 · 6c5b585 · 6c5b585
1 parent 3089b38
commit 6c5b585
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/stdlib/REPL/src/REPLCompletions.jl b/stdlib/REPL/src/REPLCompletions.jl
@@ -665,7 +665,7 @@ function completions(string, pos, context_module=Main)::Completions
                 end
             end
         end
-        ffunc = (mod,x)->(isdefined(mod, x) && isa(getfield(mod, x), Module))
+        ffunc = (mod,x)->(Base.isbindingresolved(mod, x) && isdefined(mod, x) && isa(getfield(mod, x), Module))
         comp_keywords = false
     end
     startpos == 0 && (pos = -1)

diff --git a/stdlib/REPL/test/replcompletions.jl b/stdlib/REPL/test/replcompletions.jl
@@ -105,6 +105,8 @@ end
 let s = "using REP"
     c, r = test_complete(s)
     @test count(isequal("REPL"), c) == 1
+    # issue #30234
+    @test !Base.isbindingresolved(Main, :tanh)
 end
 
 let s = "Comp"