Skip to content

Commit

Permalink
force type stability of _invoked_shouldlog & friends for non-concre…
Browse files Browse the repository at this point in the history
…te loggers (#41863)
  • Loading branch information
thchr authored Aug 18, 2021
1 parent 0771939 commit 543386d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions base/logging.jl
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,15 @@ function _invoked_shouldlog(logger, level, _module, group, id)
shouldlog,
Tuple{typeof(logger), typeof(level), typeof(_module), typeof(group), typeof(id)},
logger, level, _module, group, id
)
)::Bool
end

function _invoked_min_enabled_level(@nospecialize(logger))
return invoke(min_enabled_level, Tuple{typeof(logger)}, logger)
return invoke(min_enabled_level, Tuple{typeof(logger)}, logger)::LogLevel
end

function _invoked_catch_exceptions(@nospecialize(logger))
return invoke(catch_exceptions, Tuple{typeof(logger)}, logger)
return invoke(catch_exceptions, Tuple{typeof(logger)}, logger)::Bool
end

"""
Expand Down

2 comments on commit 543386d

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(ALL, isdaily = true)

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

Please sign in to comment.