Skip to content

Commit

Permalink
Try to put back previously flakey addmul tests (#55775)
Browse files Browse the repository at this point in the history
Partial revert of #50071, inspired by conversation in
https://github.com/JuliaLang/julia/issues/49966#issuecomment-2350935477

Ran the tests 100 times to make sure we're not putting back
something that's still flaky.

Closes #49966
  • Loading branch information
LilithHafner authored Sep 15, 2024
1 parent f4fb87b commit 4633607
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions stdlib/LinearAlgebra/test/addmul.jl
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ end
Bc = Matrix(B)
returned_mat = mul!(C, A, B, α, β)
@test returned_mat === C
# This test is skipped because it is flakey, but should be fixed and put back (see #49966)
@test_skip collect(returned_mat) α * Ac * Bc + β * Cc rtol=rtol
@test collect(returned_mat) α * Ac * Bc + β * Cc rtol=rtol

y = C[:, 1]
x = B[:, 1]
Expand All @@ -190,8 +189,7 @@ end

returned_mat = mul!(C, Af, Bf, α, β)
@test returned_mat === C
# This test is skipped because it is flakey, but should be fixed and put back (see #49966)
@test_skip collect(returned_mat) α * Ac * Bc + β * Cc rtol=rtol
@test collect(returned_mat) α * Ac * Bc + β * Cc rtol=rtol
end
end
end
Expand All @@ -203,8 +201,7 @@ end
Bc = Matrix(B)
returned_mat = mul!(C, A, B, α, zero(eltype(C)))
@test returned_mat === C
# This test is skipped because it is flakey, but should be fixed and put back (see #49966)
@test_skip collect(returned_mat) α * Ac * Bc rtol=rtol
@test collect(returned_mat) α * Ac * Bc rtol=rtol
end
end

Expand Down

0 comments on commit 4633607

Please sign in to comment.