-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
even more serializer optimizations. this breaks the serialization for…
…mat. ref #7893 - remove unnecessary extra serialization of length(x.names) - UTF16String and UTF32String now have compact type tags - don't serialize () for types with no parameters
- Loading branch information
1 parent
32d58f5
commit 31eb8d4
Showing
2 changed files
with
14 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31eb8d4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're breaking compatibility anyway, can we encode the
ser_version
in the format so we know what version something was serialized with?31eb8d4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean Jeff owes everyone dinner? #7774 (comment)
now I have to go fix Gtk
31eb8d4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API (
serialize
/deserialize
) only supports reading or writing one value at a time. There isn't anything that writes a "file", so there is not yet an obvious place to write a header.