Skip to content

Commit

Permalink
Deprecate bitbroadcast (#19771)
Browse files Browse the repository at this point in the history
* Deprecate `bitbroadcast`

* Remove `bitbroadcast` docs
  • Loading branch information
pabloferz authored and JeffBezanson committed Dec 31, 2016
1 parent a8a5ad0 commit 1b86c36
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 24 deletions.
21 changes: 1 addition & 20 deletions base/broadcast.jl
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ using Base: promote_eltype_op, linearindices, tail, OneTo, to_shape,
_msk_end, unsafe_bitgetindex, bitcache_chunks, bitcache_size, dumpbitcache,
nullable_returntype, null_safe_eltype_op, hasvalue, is_nullable_array
import Base: broadcast, broadcast!
export bitbroadcast, dotview
export broadcast_getindex, broadcast_setindex!
export broadcast_getindex, broadcast_setindex!, dotview

## Broadcasting utilities ##
# fallbacks for some special cases
Expand Down Expand Up @@ -453,24 +452,6 @@ julia> Ref(7) .+ Nullable(3)
"""
@inline broadcast(f, A, Bs...) = broadcast_c(f, containertype(A, Bs...), A, Bs...)

"""
bitbroadcast(f, As...)
Like [`broadcast`](@ref), but allocates a `BitArray` to store the
result, rather then an `Array`.
```jldoctest
julia> bitbroadcast(isodd,[1,2,3,4,5])
5-element BitArray{1}:
true
false
true
false
true
```
"""
@inline bitbroadcast(f, As...) = broadcast!(f, similar(BitArray, broadcast_indices(As...)), As...)

"""
broadcast_getindex(A, inds...)
Expand Down
3 changes: 3 additions & 0 deletions base/deprecated.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1346,6 +1346,9 @@ function quadgk(args...; kwargs...)
end
export quadgk

# Broadcast now returns a BitArray when the resulting eltype is Bool (#17623)
@deprecate bitbroadcast broadcast

# Deprecate two-argument map! (map!(f, A)) for a cycle in anticipation of semantic change
@deprecate map!{F}(f::F, A::AbstractArray) map!(f, A, A)
@deprecate asyncmap!(f, c; ntasks=0, batch_size=nothing) asyncmap!(f, c, c; ntasks=ntasks, batch_size=batch_size)
Expand Down
1 change: 0 additions & 1 deletion base/exports.jl
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,6 @@ export
zeta,

# arrays
bitbroadcast,
broadcast!,
broadcast,
broadcast_getindex,
Expand Down
1 change: 0 additions & 1 deletion doc/src/stdlib/arrays.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ All mathematical operations and functions are supported for arrays
```@docs
Base.broadcast
Base.Broadcast.broadcast!
Base.Broadcast.bitbroadcast
```

## Indexing, Assignment, and Concatenation
Expand Down
4 changes: 2 additions & 2 deletions test/bitarray.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1136,8 +1136,8 @@ let b1 = trues(v1), b2 = falses(v1)
end
end

let odds = bitbroadcast(isodd, 1:2000)
evens = bitbroadcast(iseven, 1:2000)
let odds = broadcast(isodd, 1:2000)
evens = broadcast(iseven, 1:2000)
for i = 1:2:2000
@test findprev(odds,i) == findprevnot(evens,i) == i
@test findnext(odds,i) == findnextnot(evens,i) == i
Expand Down

0 comments on commit 1b86c36

Please sign in to comment.