Fixed scale! bugs for SparseVector; added tests

JuliaLang · Sep 22, 2016 · 1530ef4 · 1530ef4
1 parent a06314b
commit 1530ef4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/base/sparse/sparsevector.jl b/base/sparse/sparsevector.jl
@@ -1358,8 +1358,8 @@ end
 
 scale!(x::AbstractSparseVector, a::Real) = (scale!(nonzeros(x), a); x)
 scale!(x::AbstractSparseVector, a::Complex) = (scale!(nonzeros(x), a); x)
-scale!(a::Real, x::AbstractSparseVector) = scale!(nonzeros(x), a)
-scale!(a::Complex, x::AbstractSparseVector) = scale!(nonzeros(x), a)
+scale!(a::Real, x::AbstractSparseVector) = (scale!(nonzeros(x), a); x)
+scale!(a::Complex, x::AbstractSparseVector) = (scale!(nonzeros(x), a); x)
 
 
 .*(x::AbstractSparseVector, a::Number) = SparseVector(length(x), copy(nonzeroinds(x)), nonzeros(x) * a)

diff --git a/test/sparsedir/sparsevector.jl b/test/sparsedir/sparsevector.jl
@@ -738,6 +738,9 @@ let x = sprand(16, 0.5), x2 = sprand(16, 0.4)
         xc = copy(x)
         @test is(scale!(xc, 2.5), xc)
         @test exact_equal(xc, sx)
+        xc = copy(x)
+        @test is(scale!(2.5, xc), xc)
+        @test exact_equal(xc, sx)
     end
 
     # dot