Fix indexing with Union{} array (#30146)

JuliaLang · Nov 25, 2018 · 024bcb7 · 024bcb7 · nanosoldier · Nov 26, 2018
1 parent f4c7779
commit 024bcb7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/base/indices.jl b/base/indices.jl
@@ -263,6 +263,7 @@ to_index(i::Integer) = convert(Int,i)::Int
 to_index(i::Bool) = throw(ArgumentError("invalid index: $i of type $(typeof(i))"))
 to_index(I::AbstractArray{Bool}) = LogicalIndex(I)
 to_index(I::AbstractArray) = I
+to_index(I::AbstractArray{Union{}}) = I
 to_index(I::AbstractArray{<:Union{AbstractArray, Colon}}) =
     throw(ArgumentError("invalid index: $I of type $(typeof(I))"))
 to_index(::Colon) = throw(ArgumentError("colons must be converted by to_indices(...)"))

diff --git a/test/abstractarray.jl b/test/abstractarray.jl
@@ -942,3 +942,8 @@ end
     @test_throws ErrorException map(identity, Set([1,2,3]))
     @test_throws ErrorException map(identity, Dict("a"=>"b"))
 end
+
+@testset "Issue 30145" begin
+    X = [1,2,3]
+    @test isempty(X[Union{}[]])
+end