Slightly optimise styled"" macro
#88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, when interpolating, the type of the expression can be inferred
as an AnnotatedString, rather than a Union{String, AnnotatedString}.
When a single styled"{$face:$content}" form is used, this optimisation
makes the macroexpansion equivalent to handwritten code for this case,
as the annotatedstring_optimize! call is superfluous when there is only
one part.
While we're at it, we may as well make annotatedstring_optimize! more
efficient for the zero and one annotation cases.
tecosaur
force-pushed
the
tiny-macro-opt
branch
from
534a022 to
03211c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin: improves type stability a bit, and optimises the single-interpolation case.