add two missing GC.@preserve calls #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild failed |
|
Well, I have no idea what this error means: |
StefanKarpinski
force-pushed
the
sk/gc-preserve
branch
from
95174de to
a803222
Compare
|
bors try |
tryBuild failed |
|
Does just copy pasting this function into its own file reproduce the error? Could file a bug upstream then. |
|
It does; I'll do that. |
|
bors try |
tryBuild succeeded |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 15, 2018
902: add two missing GC.@preserve calls r=StefanKarpinski a=StefanKarpinski I believe these are necessary. @vtjnash, can you take a quick look and verify? Co-authored-by: Stefan Karpinski <[email protected]> Co-authored-by: Kristoffer Carlsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe these are necessary. @vtjnash, can you take a quick look and verify?