Use Base.TOML.Parser{Dates} for TOML parsing w/ Dates support
#3938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to delete the `.Dates` field upstream.
These were relying on implicit `convert()` behavior in the previous constructor, which is harmless in this case but best not to depend upon.
vtjnash
reviewed
Jul 3, 2024
topolarity
force-pushed
the
ct/DTParser
branch
2 times, most recently
from
a68165e to
46416bd
Compare
topolarity
changed the title
DTParser for TOML parsing w/ Dates supportTOML.Parser for TOML parsing w/ Dates support
topolarity
force-pushed
the
ct/DTParser
branch
2 times, most recently
from
3bec0e4 to
4a89855
Compare
|
This now depends on JuliaLang/julia#55017 |
topolarity
changed the title
TOML.Parser for TOML parsing w/ Dates supportBase.TOML.Parser{Dates} for TOML parsing w/ Dates support
|
Re-running now that JuliaLang/julia#55017 is merged |
|
Probably need to wait for a new nightly first 😉 |
|
Nightlies are updated as soon as master commits are green, not nightly. The powerpc builds are lagging but otherwise all other nightlies should be up to date. |
|
The 64 bit windows nightly is a day old even though there are multiple green CI runs on julia master since.. odd. I'll give it time to resolve itself |
KristofferC
pushed a commit
that referenced
this pull request
Sep 12, 2024
* Use `Base.TOML.Parser{Dates}` for TOML parsing w/ Dates support
This will allow us to delete the `.Dates` field upstream.
* Use `Base.TOMLCache(p::TOML.Parser)` constructor
These were relying on implicit `convert()` behavior in the previous
constructor, which is harmless in this case but best not to depend upon.
---------
Co-authored-by: Ian Butterworth <[email protected]>
(cherry picked from commit e4a6723)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting to JuliaLang/julia#54755 and JuliaLang/julia#55017