Use realpaths for temp dirs during tests. Fix SparseArrays why breakage
#3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
IanButterworth
commented
Dec 16, 2023
•
IanButterworth
commented
- Avoids Coverage isn't generated if tracked path is in a symlink julia#52458
- Fixes new failure due to SparseArrays becoming a weak dep of Statistics
|
Something's going wrong in the path-specific coverage setup. I need to see what the code info source paths for the files are to compare to the coverage path, but I'm not sure how to get that |
This reverts commit 28e7d9f.
IanButterworth
changed the title
IanButterworth
changed the title
why breakage
KristofferC
reviewed
Dec 20, 2023
| @@ -1556,7 +1556,6 @@ end | |||
| @test str == | |||
| """ StaticArrays → LinearAlgebra | |||
| StaticArrays → Statistics → LinearAlgebra | |||
| StaticArrays → Statistics → SparseArrays → LinearAlgebra | |||
IanButterworth
added a commit
that referenced
this pull request
Jan 22, 2024
7 tasks
KristofferC
pushed a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.