Make tests almost entirely quiet #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/quiet_tests
branch
from
cf18c3b
to
498e1b4
Compare
IanButterworth
force-pushed
the
ib/quiet_tests
branch
from
498e1b4
to
03916b6
Compare
This reverts commit 5a19318.
DilumAluthge
approved these changes
Dec 12, 2023
| Pkg.rm(TEST_PKG.name) | ||
| end | ||
| if (Base.get_bool_env("JULIA_PKG_USE_CLI_GIT", false) == false) && !Sys.iswindows() | ||
| # TODO: fix. On GH windows runners cli git will prompt for credentials and hang. |
There was a problem hiding this comment.
Should we do a @test_skip or something? Or a @test ... skip=Sys.iswindows()?
There was a problem hiding this comment.
Can we skip testsets like that? That's what would be needed here
There was a problem hiding this comment.
Oh, hmmm, skip the whole testset? I don't think that's possible. So we're probably stuck with the existing approach.
|
Any idea why macOS CI is failing? |
IanButterworth
changed the title
|
One solid failure on MacOS is JuliaLang/julia#52458 The other is flaky git for unknown reasons. Maybe a libgit2 issue.. I don't think anyone has reported it in the wild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best I can do is only this leaking.
To do better than that we would need to reduce test coverage, or fix git cli https auth on CI, which seems difficult to figure out.
Otherwise everything is now piped into the Pkg.log which is uploaded as matrix-specific artifacts here and similar on buildkite.