Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce not running with startup file when selecting dynamic artifacts and improve error message #3109

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

KristofferC
Copy link
Member

Even if a user runs with --startup-file=1, it can cause problems to run this with the startup file enabled since the process collects output from stdout. This causes for example JuliaLang/julia#45583.

Also, in case the script outputs invalid TOML, it was hard to know what package caused this. Now it would write the error as:

ERROR: failed to parse TOML output from running "/home/kc//Pkg.jl/DynamicArtifact/.pkg/select_artifacts.jl", got: 
TOML Parser error:
none:1:6 error: expected equal sign after key
  Setup successful
       ^ 

@KristofferC KristofferC merged commit 4233434 into master Jun 15, 2022
@KristofferC KristofferC deleted the kc/dynamic_artifacts branch June 15, 2022 06:41
IanButterworth pushed a commit to IanButterworth/Pkg.jl that referenced this pull request Jun 17, 2022
…s and improve error message (JuliaLang#3109)

(cherry picked from commit 4233434)
@IanButterworth IanButterworth mentioned this pull request Jun 17, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants