Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix STDLIBS_BY_VERSION on non-latest version of Julia #2491

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Apr 6, 2021

Should fix the test error in #2425

Edit: This still need some tweaks

@KristofferC KristofferC marked this pull request as draft April 6, 2021 12:45
@IanButterworth
Copy link
Member

If it helps, there are some debug prints in the tests on master that are now backported in #2425
Over there they show

┌ Error: STDLIBS_BY_VERSION out of date!  Manually fix given the info below, or re-run generate_historical_stdlibs.jl!
└ @ Main.PkgTests.NewTests ~/work/Pkg.jl/Pkg.jl/test/new.jl:2524
length((Pkg.Types.STDLIBS_BY_VERSION[end])[2]) = 58
length(Pkg.Types.load_stdlib()) = 57
setdiff((Pkg.Types.STDLIBS_BY_VERSION[end])[2], Pkg.Types.load_stdlib()) = Pair{Base.UUID, String}[UUID("47c5dbc3-30ba-59ef-96a6-123e260183d9") => "LLVMLibUnwind_jll", UUID("8e850b90-86db-534c-a0d3-1478176c7d93") => "libblastrampoline_jll"]
setdiff(Pkg.Types.load_stdlib(), (Pkg.Types.STDLIBS_BY_VERSION[end])[2]) = Pair{Base.UUID, String}[UUID("a83860b7-747b-57cf-bf1f-3e79990d037f") => "LibOSXUnwind_jll"]
STDLIBS_BY_VERSION up-to-date: Test Failed at /home/runner/work/Pkg.jl/Pkg.jl/test/new.jl:2529

@KristofferC KristofferC marked this pull request as ready for review April 6, 2021 13:48
@KristofferC KristofferC merged commit 316bab5 into master Apr 6, 2021
@KristofferC KristofferC deleted the kc/stdlibs_version branch April 6, 2021 14:21
@fredrikekre
Copy link
Member

Looks like this is already on release-1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants