Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize Pkg.precompile #2018

Merged
merged 15 commits into from
Sep 15, 2020
Merged

Parallelize Pkg.precompile #2018

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9937dea
add is_stdlib() lookup with string name
IanButterworth Sep 13, 2020
6fb919d
depth-first parallelization for Pkg.precompile
IanButterworth Sep 13, 2020
4708b59
remove unnecessary sort
IanButterworth Sep 13, 2020
5b0e5ac
limit threads via optional ENV var
IanButterworth Sep 13, 2020
7b98298
switch to Event triggers
IanButterworth Sep 13, 2020
4b2eef4
internalize is_stdlib_from_name as unsafe for general use
IanButterworth Sep 13, 2020
84697d7
switch to Base.Semafore
IanButterworth Sep 13, 2020
8f73605
switch to uuid-based dep checking
IanButterworth Sep 13, 2020
2b1379e
force comp if any dep was recompiled
IanButterworth Sep 14, 2020
10cbdc0
move to @sync, catch and handle errors, improved wait loop
IanButterworth Sep 14, 2020
a4bdd79
remove TODOs
IanButterworth Sep 14, 2020
52ef225
skip stale check if any dep was recompiled
IanButterworth Sep 14, 2020
ab03371
add comment on any_dep_recompiled
IanButterworth Sep 14, 2020
22c4687
clearer var name
IanButterworth Sep 15, 2020
dd0ad54
improved handling of error state for jobs queued before error
IanButterworth Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/API.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,7 +915,7 @@ function precompile(ctx::Context)
precomp_events[pkgid.uuid] = Base.Event()
was_recompiled[pkgid.uuid] = false
end
# TODO: since we are a complete list, but not topologically sorted, handling of recursion will be completely at random

IanButterworth marked this conversation as resolved.
Show resolved Hide resolved
errored = false
@sync for (i, pkg) in pairs(pkgids)
paths = Base.find_all_in_cache_path(pkg)
Expand All @@ -937,7 +937,6 @@ function precompile(ctx::Context)
for path_to_try in paths::Vector{String}
staledeps = Base.stale_cachefile(sourcepath, path_to_try, Base.TOMLCache()) #|| any(deps_recompiled)
staledeps === true && continue
# TODO: else, this returns a list of packages that may be loaded to make this valid (the topological list)
stale = false
break
end
Expand Down