Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifact error on CI #1716

Closed
fredrikekre opened this issue Mar 13, 2020 · 0 comments · Fixed by #1721
Closed

Artifact error on CI #1716

fredrikekre opened this issue Mar 13, 2020 · 0 comments · Fixed by #1721
Assignees
@staticfloat
Labels
artifacts

Comments

@fredrikekre
Copy link
Member 

Artifact Creation: Error During Test at /home/travis/build/JuliaLang/Pkg.jl/test/artifacts.jl:90
  Got exception outside of a @test
  IOError: stat: permission denied (EACCES) for file "/tmp/jl_Jyzeli/artifacts/jl_Fwki2C/bar/bar"
  Stacktrace:
   [1] lstat(::String) at ./stat.jl:69
   [2] islink at ./stat.jl:314 [inlined]
   [3] rm(::String; force::Bool, recursive::Bool) at ./file.jl:260
   [4] rm(::String; force::Bool, recursive::Bool) at ./file.jl:278 (repeats 2 times)
   [5] create_artifact(::Main.PkgTests.ArtifactTests.var"#1#2"{Main.PkgTests.ArtifactTests.var"#13#25"}) at /home/travis/build/JuliaLang/Pkg.jl/src/Artifacts.jl:237

Seems to happen on Julia nightly only, see e.g. this Linux run and this macOs run.
@fredrikekre fredrikekre mentioned this issue Mar 13, 2020
Merged
This was referenced Mar 14, 2020
Closed
Closed
@KristofferC KristofferC mentioned this issue Mar 14, 2020
Merged
staticfloat added a commit that referenced this issue Mar 14, 2020
@staticfloat
Ignore symlinks when fixing permissions during artifacts tests
3722ae9 
When doing Artifact tests, we need to be resilient to strange umasks
that we have inherited from our environment, screwing up git tree hash
calculations.  To do this, we have a `walkdir()` -> `chmod()` wrapper
function that started setting permissions on what it thought were files
(due to the fixed `follow_symlink == false` behavior in
JuliaLang/julia#35006) but were actually
directories.  This caused `chmod()` to apply `0o664` permissions to
directories, which were then inaccessible to `rm()` as it tried to
delete them.

This fixes #1716
@staticfloat staticfloat mentioned this issue Mar 14, 2020
Merged
staticfloat added a commit that referenced this issue Mar 14, 2020
@staticfloat
Ignore symlinks when fixing permissions during artifacts tests (#1721)
7366c8c 
When doing Artifact tests, we need to be resilient to strange umasks
that we have inherited from our environment, screwing up git tree hash
calculations.  To do this, we have a `walkdir()` -> `chmod()` wrapper
function that started setting permissions on what it thought were files
(due to the fixed `follow_symlink == false` behavior in
JuliaLang/julia#35006) but were actually
directories.  This caused `chmod()` to apply `0o664` permissions to
directories, which were then inaccessible to `rm()` as it tried to
delete them.

This fixes #1716
fredrikekre pushed a commit that referenced this issue Apr 17, 2020
@staticfloat @fredrikekre
Ignore symlinks when fixing permissions during artifacts tests (#1721)
6087bcf 
When doing Artifact tests, we need to be resilient to strange umasks
that we have inherited from our environment, screwing up git tree hash
calculations.  To do this, we have a `walkdir()` -> `chmod()` wrapper
function that started setting permissions on what it thought were files
(due to the fixed `follow_symlink == false` behavior in
JuliaLang/julia#35006) but were actually
directories.  This caused `chmod()` to apply `0o664` permissions to
directories, which were then inaccessible to `rm()` as it tried to
delete them.

This fixes #1716

(cherry picked from commit 7366c8c, PR #1721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staticfloat staticfloat

Labels
artifacts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore symlinks when fixing permissions during artifacts tests JuliaLang/Pkg.jl
2 participants
@staticfloat @fredrikekre