-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion to add precompile_statements_file_out
option
#336
Conversation
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 81.18% 80.51% -0.67%
==========================================
Files 2 2
Lines 303 308 +5
==========================================
+ Hits 246 248 +2
- Misses 57 60 +3
Continue to review full report at Codecov.
|
@KristofferC What do you think about merging this? It seems like it would make debugging easier. |
I am hesitant adding too much API and "scaffolding" around #295. Also, can't you already get these by just running with |
I think you're right that it's a bit much to add to the API. |
The precompile files used that contain all the statements should be shown in that red wall though PackageCompiler.jl/src/PackageCompiler.jl Lines 188 to 192 in f82ac21
but I agree it might not be very discoverable. |
See what you think of the approach now. I don't feel strongly here, but might be an improvement? |
For debugging purposes. Just saves the total list to file.
Not sure if helpful in the broader sense. Just a suggestion.