shared_init option to export jl_runtime initialization into shared lib #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
- Coverage 72.59% 71.15% -1.45%
==========================================
Files 6 6
Lines 354 364 +10
==========================================
+ Hits 257 259 +2
- Misses 97 105 +8
Continue to review full report at Codecov.
|
|
Merged with PR #123, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A shared lib (DLL) produced by static compilation still requires some non-trivial housekeeping in order to safely use the
base.@ccallableexported functions. Not that terrible when dealing with C++, but a very unsatisfying experience when dealing with C# (as in my case).Therefore I've integrated into the shared library build a minimal C program that implements init_jl_runtime and exit_jl_runtime functions, so in order to use the shared library one doesn't need anything else but these two functions and his own exported functions.