Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stdlib NetworkOptions to locate system cert file #262

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

dhanak
Copy link
Contributor

@dhanak dhanak commented Feb 23, 2023

Fixes #200.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #262 (bc0c893) into master (e224150) will decrease coverage by 0.07%.
The diff coverage is 45.45%.

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   73.56%   73.49%   -0.07%     
==========================================
  Files          12       12              
  Lines         715      732      +17     
==========================================
+ Hits          526      538      +12     
- Misses        189      194       +5     
Impacted Files Coverage Δ
src/MbedTLS.jl 98.24% <ø> (+0.03%) ⬆️
src/ssl.jl 70.84% <45.45%> (-1.54%) ⬇️
src/ctr_drbg.jl 85.18% <0.00%> (+3.70%) ⬆️
src/entropy.jl 84.61% <0.00%> (+3.84%) ⬆️
src/error.jl 41.17% <0.00%> (+7.84%) ⬆️
src/debug.jl 71.42% <0.00%> (+71.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@quinnj quinnj merged commit e84f973 into JuliaLang:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get MbedTLS to use system trusted roots
3 participants