Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default cert to MozillaCACerts_jll #238

Merged
merged 4 commits into from
Jul 1, 2022
Merged

Switch default cert to MozillaCACerts_jll #238

merged 4 commits into from
Jul 1, 2022

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Jul 1, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #238 (4bfad89) into master (838b657) will increase coverage by 0.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   71.34%   71.81%   +0.46%     
==========================================
  Files          12       12              
  Lines         541      699     +158     
==========================================
+ Hits          386      502     +116     
- Misses        155      197      +42     
Impacted Files Coverage Δ
src/MbedTLS.jl 98.21% <ø> (+0.21%) ⬆️
src/ssl.jl 67.14% <100.00%> (+1.23%) ⬆️
src/debug.jl 0.00% <0.00%> (-66.67%) ⬇️
src/error.jl 35.71% <0.00%> (-5.96%) ⬇️
src/entropy.jl 83.33% <0.00%> (-4.91%) ⬇️
src/rsa.jl 81.81% <0.00%> (-3.04%) ⬇️
src/pk.jl 80.00% <0.00%> (-0.49%) ⬇️
src/ctr_drbg.jl 84.00% <0.00%> (-0.22%) ⬇️
src/gen_constants.jl 0.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4261df...4bfad89. Read the comment docs.

@quinnj quinnj merged commit 0c02e44 into master Jul 1, 2022
@quinnj quinnj deleted the jq/mozilla_jll branch July 1, 2022 12:28
@fredrikekre
Copy link
Member

@giordano
Copy link

giordano commented Jul 9, 2022

For the record, the problem was due to the Arch Linux Julia package being thoroughly broken as usual and having missing files (or not adjusting variables to point to existing files in Arch system): https://discourse.julialang.org/t/problems-installing-packages-cert-pm-no-such-file/83995/4

@fredrikekre
Copy link
Member

fredrikekre commented Jul 9, 2022

If bundling the cert has worked until now, perhaps worth at least falling back to that? Edit: #241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants