Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore UVError ECONNRESET in while isopen(ctx) / start_reading loop #149

Merged
merged 1 commit into from
May 30, 2018

Conversation

samoconnor
Copy link
Contributor

See #148

@codecov-io
Copy link

codecov-io commented May 15, 2018

Codecov Report

Merging #149 into master will decrease coverage by 0.24%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   69.57%   69.33%   -0.25%     
==========================================
  Files          10       10              
  Lines         447      450       +3     
==========================================
+ Hits          311      312       +1     
- Misses        136      138       +2
Impacted Files Coverage Δ
src/ssl.jl 72.91% <50%> (-0.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c8c0a1...274bf3e. Read the comment docs.

@s2maki
Copy link

s2maki commented May 21, 2018

Can this be reviewed and merged soon? The currently released version of MbedTLS has troubles with connection hanging, and the head of master has this bug. It would be nice to have a more stable version.

Thanks!

@samoconnor
Copy link
Contributor Author

There is another related S3 issue that is fixed by #236:
JuliaCloud/AWSS3.jl#28
@vtjnash, @quinnj It would be great to have this merged and a tag applied for this and #236.

@samoconnor samoconnor mentioned this pull request May 30, 2018
@quinnj quinnj closed this May 30, 2018
@quinnj quinnj reopened this May 30, 2018
@quinnj
Copy link
Member

quinnj commented May 30, 2018

Let's have CI re-run this just to make sure things are fresh and then we should be good to merge.

@quinnj quinnj merged commit 887be70 into JuliaLang:master May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants