Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Tag FixedPointNumbers.jl v0.3.6 #8597

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

attobot
Copy link
Contributor

@attobot attobot commented Mar 30, 2017

Repository: JuliaMath/FixedPointNumbers.jl
Release: v0.3.6
Travis: Travis Build Status
Diff: vs v0.3.5
requires vs v0.3.5: no changes
cc: @timholy

@timholy
Copy link
Member

timholy commented Mar 30, 2017

I just noticed JuliaLang/julia#21223; this change isn't strictly necessary anymore, though neither does it hurt anything. I can revert if desired.

@tkelman
Copy link
Contributor

tkelman commented Mar 30, 2017

Doesn't look like this would hurt anything? Maybe also add some mock test to base that could have caught such an ambiguity to prevent it from accidentally being added in the future?

@timholy
Copy link
Member

timholy commented Mar 30, 2017

Yeah, it definitely shouldn't hurt anything, so feel free to merge.

Adding a meaningful test is hard, because there are an infinite number of such tests that could be added. f(a::TypeA, b) defined in Base might be ambiguous with some package f(a, b::TypeB) method. I think the best we can do right now is try to be consistent about which arguments we specialize. http://docs.julialang.org/en/latest/manual/methods.html#man-method-design-ambiguities-1

@tkelman tkelman merged commit 11e8510 into JuliaLang:metadata-v2 Mar 30, 2017
@attobot attobot deleted the FixedPointNumbers/v0.3.6 branch March 30, 2017 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants