Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Tag ComputationalResources.jl v0.0.2 #8018

Merged

Conversation

attobot
Copy link
Contributor

@attobot attobot commented Feb 18, 2017

Repository: timholy/ComputationalResources.jl
Release: v0.0.2
Travis: Travis Build Status
Diff: vs v0.0.1
requires vs v0.0.1:

--- 0.0.1/requires
+++ 0.0.2/requires
@@ -1 +1,2 @@
 julia 0.4
+Compat 0.18

cc: @timholy

@@ -0,0 +1,2 @@
julia 0.4
Compat 0.18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.17 for abstract type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will keep that in mind for the future, but doesn't really hurt to demand more?

Copy link
Contributor

@tkelman tkelman Feb 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it does, it would unnecessarily prevent upgrading this package if anyone has Compat pinned for reproducibility

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix coming. But I think it's a little too picky; ImageFiltering is going to require 0.18 anyway and it's currently the only consumer. A lower bound shouldn't have to be the absolutely lowest possible lower bound; it should merely need to be sufficient to make the package work.

Copy link
Contributor

@tkelman tkelman Feb 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"known to work" is often too tight and will prevent version combinations that work fine from being installed together. bounds too loose allows installation of version combinations that don't work together. both are wrong, but with different consequences.

@attobot
Copy link
Contributor Author

attobot commented Feb 18, 2017

Repository: timholy/ComputationalResources.jl
Release: v0.0.2
Travis: Travis Build Status
Diff: vs v0.0.1
requires vs v0.0.1:

--- 0.0.1/requires
+++ 0.0.2/requires
@@ -1 +1,2 @@
 julia 0.4
+Compat 0.17

cc: @timholy

@attobot attobot force-pushed the ComputationalResources/v0.0.2 branch from b8131f0 to 0683918 Compare February 18, 2017 14:04
@tkelman tkelman merged commit 9e5c9a4 into JuliaLang:metadata-v2 Feb 18, 2017
@attobot attobot deleted the ComputationalResources/v0.0.2 branch February 18, 2017 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants