Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Tag ForwardDiff v0.2.0 #5389

Merged
merged 1 commit into from
Jun 15, 2016
Merged

Conversation

jrevels
Copy link
Member

@jrevels jrevels commented Jun 15, 2016

@tkelman tkelman merged commit 6e5a939 into JuliaLang:metadata-v2 Jun 15, 2016
@tkelman
Copy link
Contributor

tkelman commented Jun 16, 2016

This broke several of your reverse dependencies - http://pkg.julialang.org/logs/CoordinateTransformations_0.4.log and http://pkg.julialang.org/logs/LeastSquaresOptim_0.4.log. When you're tagging a "this will break things" release, please say so. You'll need to go and add upper bounds to the packages that were using ForwardDiff 0.1 features that don't work any more.

tkelman added a commit to tkelman/METADATA.jl that referenced this pull request Jun 16, 2016
@jrevels
Copy link
Member Author

jrevels commented Jun 16, 2016

Sorry about that.

ForwardDiff 0.1 features that don't work any more.

Just to avoid confusion, the new ForwardDiff still has all the same functionality; the only totally removed function was tensor, which AFAIK only a single package was using (here's how to perform that calculation now, if any onlookers are curious). Here's a recipe list for updating code that uses ForwardDiff. I should probably add the tensor trick there, as well as explicitly state that API functions are not exported and need to be fully qualified.

@tkelman
Copy link
Contributor

tkelman commented Jun 16, 2016

#5400 should mitigate half of it, looks like it was only 2 packages (out of things that were previously passing on pkgeval and not obscured by other issues).

I guess jacobian is no longer exported (I agree with that change, though we need some mechanism of adding a deprecation period for removing an export without renaming it...), and GradientNumber is gone or changed somehow?

@jrevels
Copy link
Member Author

jrevels commented Jun 16, 2016

Yes. All the ForwardDiffNumber types were reduced to a single type. A summary of the changes is here

I'll go ahead and make PRs to those two repositories to fix their ForwardDiff code.

@tkelman
Copy link
Contributor

tkelman commented Jul 23, 2016

Looks like this also broke PATHSolver but somehow that wasn't appearing on packageevaluator until now?

rofinn pushed a commit to rofinn/METADATA.jl that referenced this pull request Jul 23, 2016
rofinn pushed a commit to rofinn/METADATA.jl that referenced this pull request Jul 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants