This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perhaps |
Fair point. I was seeing it as a big eyesore, but something that won't actually change the interface of FileIO, so having the fix in 1.1.x seems acceptable to me. |
But it is pretty broken, I can't even use FileIO to load stuff |
So, does this work to load things? |
Repository: JuliaIO/FileIO.jl --- 0.9.1/requires
+++ 1.0.0/requires
@@ -1,2 +1 @@
-julia 0.6
-Compat 0.28.0
+julia 0.7-alpha cc: @SimonDanisch Please make sure that:
|
This version seems good enough for me to update all the file IO story in Queryverse to 0.7, so I'd be in favor of merging this here. |
Yeah should be mostly working! |
So, can someone merge it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repository: JuliaIO/FileIO.jl
Release: v1.0.0
Travis:
Diff: vs v0.9.1
requires
vs v0.9.1:cc: @SimonDanisch
Please make sure that: