This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
Put Julia version upper bound on a bunch of DataStructures versions #12407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They don't even load on Julia versions>=the new upper bound.
|
Ok, let us know when this is safe to merge. |
|
CC @kmsquire Does this look ok to you? Would you mind tagging a new version? |
|
Alright, new version 0.7.3 tagged, so this should be safe now. |
|
@martinholters, sorry, working through my Julia backlog and just saw this. Thanks for working through it. It generally seems fine, although I haven't checked all of the versions. |
nkottary
pushed a commit
to nkottary/METADATA.jl
that referenced
this pull request
Dec 29, 2017
…uliaLang#12407) They don't even load on Julia versions>=the new upper bound.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't even load on Julia versions>=the new upper bound.
I have no idea regarding the minimum Julia version for DataStructures v0.0.0 --- is
0.0.0ok in that case?And we should probably wait with merging this until a new DataStructures version is tagged, as the newest one installable on Julia master would otherwise be v0.2.6 which might result in unpleasant surprises, I could imagine.