Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Updates to Temporal + Indicators Packages #12011

Merged
merged 4 commits into from
Nov 28, 2017
Merged

Updates to Temporal + Indicators Packages #12011

merged 4 commits into from
Nov 28, 2017

Conversation

dysonance
Copy link
Contributor

After adding a lot more test coverage and doing a good amount of code cleaning (primarily for Temporal) the updates to these two packages offer some bugfixes and minor feature enhancements.

While most of the time I get that doing two package updates in separate PR's is generally best practice, these updates do have some interdependence and so it would be best to have them merged simultaneously.

@dysonance
Copy link
Contributor Author

Apologies for the two extraneous commits, I had issues with PkgDev.publish and so had to do this all manually this time.

@dpsanders
Copy link
Contributor

Try using Attobot instead, it's really much easier.

@aviks
Copy link
Member

aviks commented Nov 26, 2017

Strategems tests failed with this

Cannot `convert` an object of type Array{Float64,2} to an object of type Array{T,1} where T
This may have arisen from a call to the constructor Array{T,1} where T(...),
since type constructors fall back to convert methods.
Stacktrace:
 [1] cum_pnl(::Strategems.Results) at /mnt/pkgevalempty/c8d606504b75fe089b38e10fc7faae0311f7777a/Strategems/.julia/v0.6/Strategems/src/stats.jl:8
 [2] #optimize!#14(::Bool, ::Strategems.#cum_pnl, ::Array{Any,1}, ::Function, ::Strategems.Strategy) at /mnt/pkgevalempty/c8d606504b75fe089b38e10fc7faae0311f7777a/Strategems/.julia/v0.6/Strategems/src/strategy.jl:121
 [3] optimize!(::Strategems.Strategy) at /mnt/pkgevalempty/c8d606504b75fe089b38e10fc7faae0311f7777a/Strategems/.julia/v0.6/Strategems/src/strategy.jl:113
 [4] include_from_node1(::String) at ./loading.jl:569
 [5] include(::String) at ./sysimg.jl:14
 [6] process_options(::Base.JLOptions) at ./client.jl:305
 [7] _start() at ./client.jl:371
while loading /mnt/pkgevalempty/c8d606504b75fe089b38e10fc7faae0311f7777a/Strategems/.julia/v0.6/Strategems/test/runtests.jl, in expression starting on

@dysonance
Copy link
Contributor Author

@aviks I will tag/push my latest Strategems updates as well then, which should resolve this issue.

@aviks aviks merged commit d84de7a into JuliaLang:metadata-v2 Nov 28, 2017
nkottary pushed a commit to nkottary/METADATA.jl that referenced this pull request Dec 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants